Review and Merging Delay of PRs

TLDR itsnp requested a review of their PRs. After confirmation from tejaswini that the PRs were approved, itsnp pointed out they still weren't merged. tejaswini explained they were being rebased.

Photo of itsnp
itsnp
Tue, 04 Jan 2022 14:06:46 UTC

Please can someone take a look at my PR's

Photo of v_shnu
v_shnu
Wed, 05 Jan 2022 05:41:04 UTC

which pr are you talking about ?

Photo of itsnp
itsnp
Wed, 05 Jan 2022 06:38:54 UTC

<@!869641477196746813> Said you would look at it yesterday, but didn't.

Photo of tejaswini
tejaswini
Wed, 05 Jan 2022 06:43:02 UTC

Let's wait to pass circle ci

Photo of tejaswini
tejaswini
Wed, 05 Jan 2022 06:43:13 UTC

I have approved the PRs.

Photo of itsnp
itsnp
Wed, 05 Jan 2022 06:43:45 UTC

Alright, thank you!

Photo of itsnp
itsnp
Wed, 05 Jan 2022 06:48:58 UTC

<@!869641477196746813> I don't think you merged it. https://github.com/chatwoot/docs/pull/183 has completed, but not merged.

Photo of itsnp
itsnp
Wed, 05 Jan 2022 06:53:01 UTC

and this one has passed but not merged: https://github.com/chatwoot/chatwoot/pull/3685 <@!869641477196746813>

Photo of tejaswini
tejaswini
Wed, 05 Jan 2022 06:55:43 UTC

Wait it's being rebased

Photo of itsnp
itsnp
Wed, 05 Jan 2022 06:57:33 UTC

Okay