Review and Merging Delay of PRs
TLDR itsnp requested a review of their PRs. After confirmation from tejaswini that the PRs were approved, itsnp pointed out they still weren't merged. tejaswini explained they were being rebased.
v_shnu
Wed, 05 Jan 2022 05:41:04 UTCwhich pr are you talking about ?
itsnp
Wed, 05 Jan 2022 06:38:54 UTC<@!869641477196746813> Said you would look at it yesterday, but didn't.
tejaswini
Wed, 05 Jan 2022 06:43:02 UTCLet's wait to pass circle ci
tejaswini
Wed, 05 Jan 2022 06:43:13 UTCI have approved the PRs.
itsnp
Wed, 05 Jan 2022 06:43:45 UTCAlright, thank you!
itsnp
Wed, 05 Jan 2022 06:48:58 UTC<@!869641477196746813> I don't think you merged it. https://github.com/chatwoot/docs/pull/183 has completed, but not merged.
itsnp
Wed, 05 Jan 2022 06:53:01 UTCand this one has passed but not merged: https://github.com/chatwoot/chatwoot/pull/3685 <@!869641477196746813>
tejaswini
Wed, 05 Jan 2022 06:55:43 UTCWait it's being rebased
itsnp
Wed, 05 Jan 2022 06:57:33 UTCOkay
itsnp
Tue, 04 Jan 2022 14:06:46 UTCPlease can someone take a look at my PR's